Bug on DrawTileAsyncCore on EditInteractiveOverlay

gisnoob · November 9, 2021, 11:08am

I think there is a bug on DrawTileAsyncCore on EditInteractiveOverlay.
if i use 0, 90, 180, 270 angle it will rotate to proper angle other than that it will just rotate to 0 angle.

working

geoCanvas.DrawWorldImage(new GeoImage(@“Assets/DT_RIGHT_YELLOW.png”), featureCollection.BaseShape.GetCenterPoint().X, featureCollection.BaseShape.GetCenterPoint().Y, 24, 24, DrawingLevel.LevelOne, 0, 0, 90);

not working

geoCanvas.DrawWorldImage(new GeoImage(@“Assets/DT_RIGHT_YELLOW.png”), featureCollection.BaseShape.GetCenterPoint().X, featureCollection.BaseShape.GetCenterPoint().Y, 24, 24, DrawingLevel.LevelOne, 0, 0, 91);

Leo_Liu · November 11, 2021, 4:20pm

hi Gisnoob,

I can’t reproduce this issue, could you please send us a sample? and which version are you using?

Thanks,
Leo

gisnoob · November 11, 2021, 11:39pm

Unfortunately i cant send the whole code because im using postgresql database for my layers, but i can send the partial code.

    protected override Task DrawTileAsyncCore(GeoCanvas geoCanvas)
    {
        geoCanvas.DrawingQuality = DrawingQuality.HighSpeed;

        bool show_pointer = false;

        if (!mainWindow.IsNewFeatureActive)
        {
            return base.DrawTileAsyncCore(geoCanvas);
        }

        if (mainWindow.GetLayerActive().ShapeType is PointShape)
        {
            if (Point_feature != null)
            {
                if (mainWindow.GetLayerActive().Input.InputType == "SimplePoint")
                {
                    foreach (FeatureCollection featureCollection in mainWindow.TempFeatureCollection)
                    {
                        if (featureCollection.IsSelected)
                        {
                            geoCanvas.DrawEllipse(featureCollection.BaseShape.GetCenterPoint(), 3.0f, 3.0f, new GeoPen(new GeoColor(255, GeoColors.BrightYellow), 4.0f), DrawingLevel.LevelOne);
                        }
                        else
                        {
                            geoCanvas.DrawEllipse(featureCollection.BaseShape.GetCenterPoint(), 3.0f, 3.0f, new GeoPen(new GeoColor(255, GeoColors.Aqua), 3.0f), DrawingLevel.LevelOne);
                        }

                        geoCanvas.DrawTextWithScreenCoordinate($"{featureCollection.FeatureLabel}", new GeoFont("Segoe UI", 10.0f, DrawingFontStyles.Bold), GeoBrushes.DarkRed, new GeoPen(GeoColor.FromHtml("#FFFFFF"), 1.5f), (float)MapUtil.ToScreenCoordinate(featureCollection.BaseShape, mapView.CurrentExtent, (float)mapView.ActualWidth, (float)mapView.ActualHeight).GetCenterPoint().X, (float)MapUtil.ToScreenCoordinate(featureCollection.BaseShape, mapView.CurrentExtent, (float)mapView.ActualWidth, (float)mapView.ActualHeight).GetCenterPoint().Y - 10, DrawingLevel.LevelOne);
                    }
                    geoCanvas.DrawEllipse(Point_feature, 3.0f, 3.0f, new GeoPen(new GeoColor(255, GeoColors.BrightRed), 3.0f), DrawingLevel.LevelOne);
                }
                if (mainWindow.GetLayerActive().Input.InputType == "Image")
                {
                    foreach (FeatureCollection featureCollection in mainWindow.TempFeatureCollection)
                    {
                        geoCanvas.DrawTextWithScreenCoordinate($"{featureCollection.FeatureLabel}", new GeoFont("Segoe UI", 10.0f, DrawingFontStyles.Bold), GeoBrushes.DarkRed, new GeoPen(GeoColor.FromHtml("#FFFFFF"), 1.5f), (float)MapUtil.ToScreenCoordinate(featureCollection.BaseShape, mapView.CurrentExtent, (float)mapView.ActualWidth, (float)mapView.ActualHeight).GetCenterPoint().X, (float)MapUtil.ToScreenCoordinate(featureCollection.BaseShape, mapView.CurrentExtent, (float)mapView.ActualWidth, (float)mapView.ActualHeight).GetCenterPoint().Y - 10, DrawingLevel.LevelOne);
                    }
                    if (!is_edit)
                    {
                        geoCanvas.DrawWorldImage(new GeoImage(@"Assets/DT_RIGHT_CYAN.png"), Point_feature.GetShape().GetCenterPoint().X, Point_feature.GetShape().GetCenterPoint().Y, 24, 24, DrawingLevel.LevelFour, 0, 0, 0);
                    }
                    else
                    {
                        geoCanvas.DrawEllipse(Point_feature, 3.0f, 3.0f, new GeoPen(new GeoColor(255, GeoColors.BrightRed), 3.0f), DrawingLevel.LevelOne);
                    }
                }
            }

            return base.DrawTileAsyncCore(geoCanvas);
        }


        return base.DrawTileAsyncCore(geoCanvas);
    }

gisnoob · November 11, 2021, 11:46pm

Im using the latest version btw.

Leo_Liu · November 16, 2021, 4:26pm

Hi gisnoob,

Thanks for your code. I reproduced your issue. I think your code makes sense, we’ll fix it as soon as possible.

As of right now, you could use the following code to rotate the image to any angle:

    protected override Task DrawTileAsyncCore(GeoCanvas geoCanvas)
    {
        // call base.DrawTileAsyncCore first, then DrawWorldImage
        Task task = base.DrawTileAsyncCore(geoCanvas);

        PointShape p = geoCanvas.CurrentWorldExtent.GetCenterPoint();
        geoCanvas.DrawWorldImage(new GeoImage(@"Assets/DT_RIGHT_YELLOW.png"), featureCollection.BaseShape.GetCenterPoint().X, featureCollection.BaseShape.GetCenterPoint().Y, 24, 24, DrawingLevel.LevelOne, 0, 0, 91);

        return task;
    }

Thanks,
Leo

gisnoob · November 17, 2021, 12:29am

Thanks! hope to see the fix/patch soon cuz this will significantly shorten my codes.

gisnoob · November 17, 2021, 1:50am

i can rotate to any angle but the problem is if i have 2 or more features it will just display the last added feature.

Leo_Liu · November 17, 2021, 3:08pm

Hi Gisnoob,

I’ve fixed it, you could upgrade your ThinkGeo.UI.Wpf to 13.0.0-beta370 or above to give it a try. And let me know if the problem still exists.

Thanks,
Leo

gisnoob · November 17, 2021, 3:58pm

will wait for the beta370 its not yet available on nuget

gisnoob · November 18, 2021, 1:08am

still the problem still exists,

If the collection has only one feature, there is no problem i can rotate it to any angle, the bug will occur if collection has 2 or more features. can you check it?

Leo_Liu · November 23, 2021, 3:58pm

Hi Gisnoob,

Thanks for your feedback. I reproduced the issue and have fixed it, you could upgrade your ThinkGeo.UI.Wpf to 13.0.0-beta372 or above to give it a try.

Thanks,
Leo

gisnoob · November 24, 2021, 1:50am

multiple feature fix but it has another problem, the when i click to add the feature it is not centered or it is not aligned with the center point that is set, it seems that the x coordinate it going to the negative side.

Leo_Liu · November 25, 2021, 3:24pm

Hi,

Yes, it’s a bug. I’ve fixed it. Could you upgrade your ThinkGeo.UI.Wpf to 13.0.0-beta373 or above to give it a try?

Thanks,
Leo

gisnoob · November 26, 2021, 1:17am

one last problem if I call DrawCore and mapview.refresh() i get

Exception thrown: ‘System.InvalidCastException’ in System.Private.CoreLib.dll
An unhandled exception of type ‘System.InvalidCastException’ occurred in System.Private.CoreLib.dll
Unable to cast object of type ‘System.Windows.Controls.Canvas’ to type ‘ThinkGeo.Core.TileView’

Leo_Liu · November 29, 2021, 3:46pm

hi,

I’m not sure if I understand correctly. Do you mean you call DrawCore method and then call MapView.refersh in your code? Could you post your code here, so we can have a better understanding?

Thanks,
Leo

gisnoob · November 30, 2021, 2:04pm

yes i call also refresh because i have to reload an overlay aside from drawcore.

Leo_Liu · December 6, 2021, 3:47pm

hi,

It looks like you passed a wrong type to DrawCore. I cannot reproduce this problem, Could you post the code snippet?

Thanks,
Leo

gisnoob · December 7, 2021, 2:01am

i think it is a bug because commenting out the previous bug like custom angle/rotation on DrawCore, Exception is not called.

Leo_Liu · December 14, 2021, 3:14pm

Yes, it looks like a bug. But I still couldn’t reproduce it. Could do send us a really simple project to demonstrate this?

Thanks,
Leo